Repository navigation
Fail a click that cannot land - #40
Merged
Merged
Conversation
click, dblclick, hover, check, uncheck and the source of a drag check what is at the point they press, wait while something else would receive it, and fail naming what does (or that nothing is there). Before, a click on a covered or off-screen element reported success and a later step timed out far from the cause. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Mpdreamz
force-pushed
the
feature/click-hit-test
branch
from
November 10, 2026 11:05
8329dca to
5e97430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reported from docs-builder journeys:
find role link click --name "Quick reference" --exactcompleted with no error while the click did nothing, with no request and no URL change. Chrome deliversInput.dispatchMouseEventto whatever is at the point, so a click on a covered or off-screen element "succeeds", and the failure shows at a later step that times out far from the cause.What
click,dblclick,hover,check,uncheckand the source ofdragcheckelementFromPointat the point they are about to press (descending into shadow roots). Scrolling and a drag's target press nothing, so they are unchanged.Timed out after 5s waiting for role link --name … to receive a click at (84, 412): <div#cookie-banner.banner> would receive it instead., ornothing is there: it is outside the viewport or clipped.<label>whose control is the element (custom switches hide their input under the label).pointer-events: noneis skipped by the browser, as for a real click.Verification
New fixture page and live tests: uncovered click lands, covered click fails naming the cover and never sends the click, a cover that goes away is waited out,
pointer-events: nonepasses through, off-screen, custom switch through its label, element inside a button, hover and drag source, and the same failure as a journey step. All 435 .NET tests pass, existing click tests included. Made the hit check accept anything once: 5 of 9 new tests failed.No release or publish.
🤖 Generated with Claude Code